• Sudip Mukherjee's avatar
    netcp: use pointer to fix build fail · 0c71de66
    Sudip Mukherjee authored
    While building keystone_defconfig of arm we are getting build failure
    with the error:
    
    drivers/net/ethernet/ti/netcp_core.c:1846:31: error: invalid type argument of '->' (have 'struct tc_to_netdev')
      if (handle != TC_H_ROOT || tc->type != TC_SETUP_MQPRIO)
                                   ^
    drivers/net/ethernet/ti/netcp_core.c:1851:35: error: invalid type argument of '->' (have 'struct tc_to_netdev')
          (dev->real_num_tx_queues < tc->tc))
                                       ^
    drivers/net/ethernet/ti/netcp_core.c:1855:8: error: invalid type argument of '->' (have 'struct tc_to_netdev')
      if (tc->tc) {
            ^
    drivers/net/ethernet/ti/netcp_core.c:1856:28: error: invalid type argument of '->' (have 'struct tc_to_netdev')
       netdev_set_num_tc(dev, tc->tc);
                                ^
    drivers/net/ethernet/ti/netcp_core.c:1857:21: error: invalid type argument of '->' (have 'struct tc_to_netdev')
       for (i = 0; i < tc->tc; i++)
                         ^
    drivers/net/ethernet/ti/netcp_core.c: At top level:
    drivers/net/ethernet/ti/netcp_core.c:1879:2: warning: initialization from incompatible pointer type
      .ndo_setup_tc  = netcp_setup_tc,
      ^
    
    The callback of ndo_setup_tc should be:
    int (*ndo_setup_tc)(struct net_device *dev, u32 handle, __be16 protocol,
                        struct tc_to_netdev *tc);
    
    But we missed marking the last argument as a pointer.
    
    Fixes: 16e5cc64 ("net: rework setup_tc ndo op to consume general tc operand")
    CC: John Fastabend <john.r.fastabend@intel.com>
    Signed-off-by: default avatarSudip Mukherjee <sudip.mukherjee@codethink.co.uk>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    0c71de66
netcp_core.c 56.6 KB