• Pierre-Louis Bossart's avatar
    ASoC: soc-pcm: protect BE dailink state changes in trigger · 0c75fc71
    Pierre-Louis Bossart authored
    When more than one FE is connected to a BE, e.g. in a mixing use case,
    the BE can be triggered multiple times when the FE are opened/started
    concurrently. This race condition is problematic in the case of
    SoundWire BE dailinks, and this is not desirable in a general
    case. The code carefully checks when the BE can be stopped or
    hw_free'ed, but the trigger code does not use any mutual exclusion.
    
    Fix by using the same spinlock already used to check FE states, and
    set the state before the trigger. In case of errors,  the initial
    state will be restored.
    
    This patch does not change how the triggers are handled, it only makes
    sure the states are handled in critical sections.
    Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    Message-Id: <20210817164054.250028-2-pierre-louis.bossart@linux.intel.com>
    Signed-off-by: default avatarMark Brown <broonie@kernel.org>
    0c75fc71
soc-pcm.c 78 KB