• Sean Christopherson's avatar
    KVM: SVM: Probe and load MSR_TSC_AUX regardless of RDTSCP support in host · 0caa0a77
    Sean Christopherson authored
    Probe MSR_TSC_AUX whether or not RDTSCP is supported in the host, and
    if probing succeeds, load the guest's MSR_TSC_AUX into hardware prior to
    VMRUN.  Because SVM doesn't support interception of RDPID, RDPID cannot
    be disallowed in the guest (without resorting to binary translation).
    Leaving the host's MSR_TSC_AUX in hardware would leak the host's value to
    the guest if RDTSCP is not supported.
    
    Note, there is also a kernel bug that prevents leaking the host's value.
    The host kernel initializes MSR_TSC_AUX if and only if RDTSCP is
    supported, even though the vDSO usage consumes MSR_TSC_AUX via RDPID.
    I.e. if RDTSCP is not supported, there is no host value to leak.  But,
    if/when the host kernel bug is fixed, KVM would start leaking MSR_TSC_AUX
    in the case where hardware supports RDPID but RDTSCP is unavailable for
    whatever reason.
    
    Probing MSR_TSC_AUX will also allow consolidating the probe and define
    logic in common x86, and will make it simpler to condition the existence
    of MSR_TSX_AUX (from the guest's perspective) on RDTSCP *or* RDPID.
    
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
    Message-Id: <20210504171734.1434054-7-seanjc@google.com>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    0caa0a77
svm.c 124 KB