• Jarod Wilson's avatar
    random: update interface comments to reflect reality · 442a4fff
    Jarod Wilson authored
    At present, the comment header in random.c makes no mention of
    add_disk_randomness, and instead, suggests that disk activity adds to the
    random pool by way of add_interrupt_randomness, which appears to not have
    been the case since sometime prior to the existence of git, and even prior
    to bitkeeper. Didn't look any further back. At least, as far as I can
    tell, there are no storage drivers setting IRQF_SAMPLE_RANDOM, which is a
    requirement for add_interrupt_randomness to trigger, so the only way for a
    disk to contribute entropy is by way of add_disk_randomness. Update
    comments accordingly, complete with special mention about solid state
    drives being a crappy source of entropy (see e2e1a148 for reference).
    Signed-off-by: default avatarJarod Wilson <jarod@redhat.com>
    Acked-by: default avatarMatt Mackall <mpm@selenic.com>
    Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
    442a4fff
random.c 48.7 KB