• Yazen Ghannam's avatar
    EDAC/mce_amd: Use struct cpuinfo_x86.cpu_die_id for AMD NodeId · 8de0c991
    Yazen Ghannam authored
    The edac_mce_amd module calls decode_dram_ecc() on AMD Family17h and
    later systems. This function is used in amd64_edac_mod to do
    system-specific decoding for DRAM ECC errors. The function takes a
    "NodeId" as a parameter.
    
    In AMD documentation, NodeId is used to identify a physical die in a
    system. This can be used to identify a node in the AMD_NB code and also
    it is used with umc_normaddr_to_sysaddr().
    
    However, the input used for decode_dram_ecc() is currently the NUMA node
    of a logical CPU. In the default configuration, the NUMA node and
    physical die will be equivalent, so this doesn't have an impact.
    
    But the NUMA node configuration can be adjusted with optional memory
    interleaving modes. This will cause the NUMA node enumeration to not
    match the physical die enumeration. The mismatch will cause the address
    translation function to fail or report incorrect results.
    
    Use struct cpuinfo_x86.cpu_die_id for the node_id parameter to ensure the
    physical ID is used.
    
    Fixes: fbe63acf ("EDAC, mce_amd: Use cpu_to_node() to find the node ID")
    Signed-off-by: default avatarYazen Ghannam <yazen.ghannam@amd.com>
    Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
    Link: https://lkml.kernel.org/r/20201109210659.754018-4-Yazen.Ghannam@amd.com
    8de0c991
mce_amd.c 29.6 KB