• Zach O'Keefe's avatar
    mm/madvise: MADV_COLLAPSE return EAGAIN when page cannot be isolated · 0f3e2a2c
    Zach O'Keefe authored
    MADV_COLLAPSE is a best-effort request that attempts to set an actionable
    errno value if the request cannot be fulfilled at the time.  EAGAIN should
    be used to communicate that a resource was temporarily unavailable, but
    that the user may try again immediately.
    
    SCAN_DEL_PAGE_LRU is an internal result code used when a page cannot be
    isolated from it's LRU list.  Since this, like SCAN_PAGE_LRU, is likely a
    transitory state, make MADV_COLLAPSE return EAGAIN so that users know they
    may reattempt the operation.
    
    Another important scenario to consider is race with khugepaged. 
    khugepaged might isolate a page while MADV_COLLAPSE is interested in it. 
    Even though racing with khugepaged might mean that the memory has already
    been collapsed, signalling an errno that is non-intrinsic to that memory
    or arguments provided to madvise(2) lets the user know that future
    attempts might (and in this case likely would) succeed, and avoids
    false-negative assumptions by the user.
    
    Link: https://lkml.kernel.org/r/20220922184651.1016461-1-zokeefe@google.com
    Fixes: 7d8faaf1 ("mm/madvise: introduce MADV_COLLAPSE sync hugepage collapse")
    Signed-off-by: default avatarZach O'Keefe <zokeefe@google.com>
    Cc: Axel Rasmussen <axelrasmussen@google.com>
    Cc: Chris Kennelly <ckennelly@google.com>
    Cc: David Hildenbrand <david@redhat.com>
    Cc: David Rientjes <rientjes@google.com>
    Cc: Hugh Dickins <hughd@google.com>
    Cc: James Houghton <jthoughton@google.com>
    Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
    Cc: Matthew Wilcox <willy@infradead.org>
    Cc: Miaohe Lin <linmiaohe@huawei.com>
    Cc: Minchan Kim <minchan@kernel.org>
    Cc: Pasha Tatashin <pasha.tatashin@soleen.com>
    Cc: Peter Xu <peterx@redhat.com>
    Cc: Rongwei Wang <rongwei.wang@linux.alibaba.com>
    Cc: SeongJae Park <sj@kernel.org>
    Cc: Song Liu <songliubraving@fb.com>
    Cc: Vlastimil Babka <vbabka@suse.cz>
    Cc: Yang Shi <shy828301@gmail.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    0f3e2a2c
khugepaged.c 63.1 KB