• Javier Carrasco's avatar
    hwmon: (adt7475) Fix memory leak in adt7475_fan_pwm_config() · 0fb09bf7
    Javier Carrasco authored
    The device_for_each_child_node() loop requires calls to
    fwnode_handle_put() upon early returns to decrement the refcount of
    the child node and avoid leaking memory.
    
    There are multiple early returns within that loop in
    adt7475_fan_pwm_config(), but fwnode_handle_put() is never called.
    Instead of adding the missing calls, the scoped version of the loop can
    be used to simplify the code and avoid mistakes in the future if new
    early returns are added.
    
    This issue was recently introduced and it does not affect old kernels
    that do not support the scoped variant.
    
    Fixes: 777c97ff ("hwmon: (adt7475) Add support for configuring initial PWM state")
    Signed-off-by: default avatarJavier Carrasco <javier.carrasco.cruz@gmail.com>
    Message-ID: <20240926-hwmon_adt7475_memleak-v1-1-89b8ee07507a@gmail.com>
    Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
    0fb09bf7
adt7475.c 56.4 KB