• KP Singh's avatar
    bpf: Allow bpf_local_storage to be used by sleepable programs · 0fe4b381
    KP Singh authored
    Other maps like hashmaps are already available to sleepable programs.
    Sleepable BPF programs run under trace RCU. Allow task, sk and inode
    storage to be used from sleepable programs. This allows sleepable and
    non-sleepable programs to provide shareable annotations on kernel
    objects.
    
    Sleepable programs run in trace RCU where as non-sleepable programs run
    in a normal RCU critical section i.e.  __bpf_prog_enter{_sleepable}
    and __bpf_prog_exit{_sleepable}) (rcu_read_lock or rcu_read_lock_trace).
    
    In order to make the local storage maps accessible to both sleepable
    and non-sleepable programs, one needs to call both
    call_rcu_tasks_trace and call_rcu to wait for both trace and classical
    RCU grace periods to expire before freeing memory.
    
    Paul's work on call_rcu_tasks_trace allows us to have per CPU queueing
    for call_rcu_tasks_trace. This behaviour can be achieved by setting
    rcupdate.rcu_task_enqueue_lim=<num_cpus> boot parameter.
    
    In light of these new performance changes and to keep the local storage
    code simple, avoid adding a new flag for sleepable maps / local storage
    to select the RCU synchronization (trace / classical).
    
    Also, update the dereferencing of the pointers to use
    rcu_derference_check (with either the trace or normal RCU locks held)
    with a common bpf_rcu_lock_held helper method.
    Signed-off-by: default avatarKP Singh <kpsingh@kernel.org>
    Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
    Acked-by: default avatarMartin KaFai Lau <kafai@fb.com>
    Link: https://lore.kernel.org/bpf/20211224152916.1550677-2-kpsingh@kernel.org
    0fe4b381
bpf_task_storage.c 8.33 KB