• Arnaldo Carvalho de Melo's avatar
    perf symbols: Improve kallsyms symbol end addr calculation · 3b01a413
    Arnaldo Carvalho de Melo authored
    For kallsyms we don't have the symbol address end, so we do an extra pass and
    set the symbol end addr as being the start of the next minus one.
    
    But this was being done just after we filtered the symbols of a
    particular type (functions, variables), so the symbol end was sometimes
    after what it really is.
    
    Fixing up symbol end also was falling apart when we have symbol aliases,
    then the end address of all but the last alias was being set to be
    before its start.
    
    Fix it up by checking for symbol aliases and making the kallsyms__parse
    routine use the next symbol, whatever its type, as the limit for the
    previous symbol, passing that end address to the callback.
    
    This was detected by the 'perf test' synthetic paranoid regression
    tests, fix it up so that even that case doesn't mislead us.
    
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Stephane Eranian <eranian@google.com>
    LKML-Reference: <new-submission>
    Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    3b01a413
event.c 23.5 KB