• Dave Chinner's avatar
    xfs: fix CIL sparse lock context warnings · 2c03d956
    Dave Chinner authored
    Sparse reports:
    
    fs/xfs/xfs_log_cil.c:1127:1: warning: context imbalance in 'xlog_cil_push_work' - different lock contexts for basic block
    fs/xfs/xfs_log_cil.c:1380:1: warning: context imbalance in 'xlog_cil_push_background' - wrong count at exit
    fs/xfs/xfs_log_cil.c:1623:9: warning: context imbalance in 'xlog_cil_commit' - unexpected unlock
    
    xlog_cil_push_background() has a locking annotations for an rw_sem.
    Sparse does not track lock contexts for rw_sems, so the
    annotation generates false warnings. Remove the annotation.
    
    xlog_wait_on_iclog() drops the log->l_ic_loglock. The function has a
    sparse annotation, but the prototype in xfs_log_priv.h does not.
    Hence the warning from xlog_cil_push_work() which calls
    xlog_wait_on_iclog(). Add the missing annotation.
    Signed-off-by: default avatarDave Chinner <dchinner@redhat.com>
    Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
    Signed-off-by: default avatarChandan Babu R <chandanbabu@kernel.org>
    2c03d956
xfs_log_cil.c 57 KB