• Jeff Garzik's avatar
    Revert "pata_octeon_cf: perform host detach, removal on exit" · 11ace0c1
    Jeff Garzik authored
    This reverts commit 1645bf1b.
    
    Brian Norris writes:
      > David Daney writes:
    
      > I can seem to find it.  Without knowing what that does, I would be inclined
      > to NACK the whole thing.
    
      A NACK is probably the right thing. I was mostly converting a few
      other drivers which used some simple, common patterns to use my new
      common code, but this driver was missing it altogether. It looks like
      there may be bigger issues, though, as you point out.
    
      > This patch is likely to be incomplete as the driver is also missing the
      > module_exit() things.
      >
      > It might be simpler to just make the driver "bool" instead of "tristate" in
      > the Kconfig.
    
      As noted earlier, I don't have much interest in this driver. I agree
      that there are some other issues with the driver; I think it leaks
      memory if it is ever allowed to unload, for one. Feel free to submit
      an alternative patch to prevent this driver from being built as a
      module.
    Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
    11ace0c1
pata_octeon_cf.c 24 KB