• Jianchao Wang's avatar
    nvme: fix use-after-free in nvme_free_ns_head · 12d9f070
    Jianchao Wang authored
    Currently only nvme_ctrl will take a reference counter of
    nvme_subsystem, nvme_ns_head also needs it. Otherwise
    nvme_free_ns_head will access the nvme_subsystem.ns_ida
    which has been freed by __nvme_release_subsystem after all the
    reference of nvme_subsystem have been released by nvme_free_ctrl.
    This could cause memory corruption.
    
     BUG: KASAN: use-after-free in radix_tree_next_chunk+0x9f/0x4b0
     Read of size 8 at addr ffff88036494d2e8 by task fio/1815
    
     CPU: 1 PID: 1815 Comm: fio Kdump: loaded Tainted: G        W         4.17.0-rc1+ #18
     Hardware name: LENOVO 10MLS0E339/3106, BIOS M1AKT22A 06/27/2017
     Call Trace:
      dump_stack+0x91/0xeb
      print_address_description+0x6b/0x290
      kasan_report+0x261/0x360
      radix_tree_next_chunk+0x9f/0x4b0
      ida_remove+0x8b/0x180
      ida_simple_remove+0x26/0x40
      nvme_free_ns_head+0x58/0xc0
      __blkdev_put+0x30a/0x3a0
      blkdev_close+0x44/0x50
      __fput+0x184/0x380
      task_work_run+0xaf/0xe0
      do_exit+0x501/0x1440
      do_group_exit+0x89/0x140
      __x64_sys_exit_group+0x28/0x30
      do_syscall_64+0x72/0x230
    Signed-off-by: default avatarJianchao Wang <jianchao.w.wang@oracle.com>
    Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
    Signed-off-by: default avatarKeith Busch <keith.busch@intel.com>
    12d9f070
core.c 90.4 KB