• Glauber Costa's avatar
    net: decrement memcg jump label when limit, not usage, is changed · 1398eee0
    Glauber Costa authored
    The logic of the current code is that whenever we destroy
    a cgroup that had its limit set (set meaning different than
    maximum), we should decrement the jump_label counter.
    Otherwise we assume it was never incremented.
    
    But what the code actually does is test for RES_USAGE
    instead of RES_LIMIT. Usage being different than maximum
    is likely to be true most of the time.
    
    The effect of this is that the key must become negative,
    and since the jump_label test says:
    
            !!atomic_read(&key->enabled);
    
    we'll have jump_labels still on when no one else is
    using this functionality.
    Signed-off-by: default avatarGlauber Costa <glommer@parallels.com>
    CC: David S. Miller <davem@davemloft.net>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    1398eee0
tcp_memcontrol.c 6.59 KB