• Gui Jianfeng's avatar
    SCTP: Fix chunk parameter processing bug · 140ee960
    Gui Jianfeng authored
    If an address family is not listed in "Supported Address Types"
    parameter(INIT Chunk), but the packet is sent by that family, this
    address family should be considered as supported by peer.  Otherwise,
    an error condition will occur. For instance, if kernel receives an
    IPV6 SCTP INIT chunk with "Support Address Types" parameter which
    indicates just supporting IPV4 Address family. Kernel will reply an
    IPV6 SCTP INIT ACK packet, but the source ipv6 address in ipv6 header
    will be vacant. This is not correct.
    
    refer to RFC4460 as following:
          IMPLEMENTATION NOTE: If an SCTP endpoint lists in the 'Supported
          Address Types' parameter either IPv4 or IPv6, but uses the other
          family for sending the packet containing the INIT chunk, or if it
          also lists addresses of the other family in the INIT chunk, then
          the address family that is not listed in the 'Supported Address
          Types' parameter SHOULD also be considered as supported by the
          receiver of the INIT chunk.  The receiver of the INIT chunk SHOULD
          NOT respond with any kind of error indication.
    
    Here is a fix to comply to RFC.
    Signed-off-by: default avatarGui Jianfeng <guijianfeng@cn.fujitsu.com>
    Acked-by: default avatarVlad Yasevich <vladislav.yasevich@hp.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    140ee960
sm_make_chunk.c 95.6 KB