• Russell King's avatar
    [ARM] omap: clk_set_parent: deny changing parent if clock is enabled · 4da37821
    Russell King authored
    Richard Woodruff writes:
    | The historic usage of this has been against single use leaf clocks
    | (1st instance of gptimer).  When it was used it did:
    |       clk_get()
    |       clk_set_parent()
    |       clk_enable()
    |
    | This usage was ok for that. Use on a disabled clock is needed.
    |
    | If there are multiple users on the clock or it is enabled there are
    | problems.
    |
    | The call can still be unfriendly if 2 different drivers are using the
    | clock with their own clock get/enable. It might be the function should
    | return an error if usecount != 0 to stop surprises.  It is all around
    | better if the parenting is done when the clock is off.
    
    This is a good reason to ensure that the clock is not enabled when
    clk_set_parent() is called.
    Acked-by: default avatarRichard Woodruff <r-woodruff2@ti.com>
    Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
    4da37821
clock.c 9.5 KB