• Mauricio Faria de Oliveira's avatar
    partitions/aix: fix usage of uninitialized lv_info and lvname structures · 14cb2c8a
    Mauricio Faria de Oliveira authored
    The if-block that sets a successful return value in aix_partition()
    uses 'lvip[].pps_per_lv' and 'n[].name' potentially uninitialized.
    
    For example, if 'numlvs' is zero or alloc_lvn() fails, neither is
    initialized, but are used anyway if alloc_pvd() succeeds after it.
    
    So, make the alloc_pvd() call conditional on their initialization.
    
    This has been hit when attaching an apparently corrupted/stressed
    AIX LUN, misleading the kernel to pr_warn() invalid data and hang.
    
        [...] partition (null) (11 pp's found) is not contiguous
        [...] partition (null) (2 pp's found) is not contiguous
        [...] partition (null) (3 pp's found) is not contiguous
        [...] partition (null) (64 pp's found) is not contiguous
    
    Fixes: 6ceea22b ("partitions: add aix lvm partition support files")
    Signed-off-by: default avatarMauricio Faria de Oliveira <mfo@canonical.com>
    Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
    14cb2c8a
aix.c 6.33 KB