• Florian Westphal's avatar
    Revert "ipv4: use skb coalescing in defragmentation" · 14fe22e3
    Florian Westphal authored
    This reverts commit 3cc49492.
    
    There is nothing wrong with coalescing during defragmentation, it
    reduces truesize overhead and simplifies things for the receiving
    socket (no fraglist walk needed).
    
    However, it also destroys geometry of the original fragments.
    While that doesn't cause any breakage (we make sure to not exceed largest
    original size) ip_do_fragment contains a 'fastpath' that takes advantage
    of a present frag list and results in fragments that (in most cases)
    match what was received.
    
    In case its needed the coalescing could be done later, when we're sure
    the skb is not forwarded.  But discussion during NFWS resulted in
    'lets just remove this for now'.
    
    Cc: Eric Dumazet <edumazet@google.com>
    Signed-off-by: default avatarFlorian Westphal <fw@strlen.de>
    Acked-by: default avatarEric Dumazet <edumazet@google.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    14fe22e3
ip_fragment.c 20.8 KB