• Sachin Prabhu's avatar
    Open with O_CREAT flag set fails to open existing files on non writable directories · 1574dff8
    Sachin Prabhu authored
    An open on a NFS4 share using the O_CREAT flag on an existing file for
    which we have permissions to open but contained in a directory with no
    write permissions will fail with EACCES.
    
    A tcpdump shows that the client had set the open mode to UNCHECKED which
    indicates that the file should be created if it doesn't exist and
    encountering an existing flag is not an error. Since in this case the
    file exists and can be opened by the user, the NFS server is wrong in
    attempting to check create permissions on the parent directory.
    
    The patch adds a conditional statement to check for create permissions
    only if the file doesn't exist.
    Signed-off-by: default avatarSachin S. Prabhu <sprabhu@redhat.com>
    Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
    1574dff8
vfs.c 53.2 KB