• Vlad Buslov's avatar
    tc-testing: concurrency: wrap piped rule update commands · 14b54ac4
    Vlad Buslov authored
    Concurrent tests use several commands to update rules in parallel: 'find'
    prints names of batch files in tmp directory and pipes result to 'xargs'
    which runs instance of tc per batch file in parallel. This breaks when used
    with ns plugin that adds 'ip netns exec $NS' prefix to the command, which
    causes only first command in pipe to be executed in namespace:
    
    =====> Test e41d: Add 1M flower filters with 10 parallel tc instances
    -----> prepare stage
    ns/SubPlugin.adjust_command
    adjust_command:  stage is setup; inserting netns stuff in command [/bin/mkdir tmp] list [['/bin/mkdir', 'tmp']]
    adjust_command:  return command [ip netns exec tcut /bin/mkdir tmp]
    command "ip netns exec tcut /bin/mkdir tmp"
    ns/SubPlugin.adjust_command
    adjust_command:  stage is setup; inserting netns stuff in command [/sbin/tc qdisc add dev ens1f0 ingress] list [['/sbin/tc', 'qdisc', 'add', 'dev', 'ens1f0', 'ingress']]
    adjust_command:  return command [ip netns exec tcut /sbin/tc qdisc add dev ens1f0 ingress]
    command "ip netns exec tcut /sbin/tc qdisc add dev ens1f0 ingress"
    ns/SubPlugin.adjust_command
    adjust_command:  stage is setup; inserting netns stuff in command [./tdc_multibatch.py ens1f0 tmp 100000 10 add] list [['./tdc_multibatch.py', 'ens1f0', 'tmp', '100000', '10', 'add']]
    adjust_command:  return command [ip netns exec tcut ./tdc_multibatch.py ens1f0 tmp 100000 10 add]
    command "ip netns exec tcut ./tdc_multibatch.py ens1f0 tmp 100000 10 add"
    -----> execute stage
    ns/SubPlugin.adjust_command
    adjust_command:  stage is execute; inserting netns stuff in command [find tmp/add* -print | xargs -n 1 -P 10 /sbin/tc -b] list [['find', 'tmp/add*', '-print', '|', 'xargs', '-n', '1', '-P', '10', '/sbin/tc', '-b']
    ]
    adjust_command:  return command [ip netns exec tcut find tmp/add* -print | xargs -n 1 -P 10 /sbin/tc -b]
    command "ip netns exec tcut find tmp/add* -print | xargs -n 1 -P 10 /sbin/tc -b"
    exit: 123
    exit: 0
    Cannot find device "ens1f0"
    Cannot find device "ens1f0"
    Command failed tmp/add_0:1
    Command failed tmp/add_1:1
    Cannot find device "ens1f0"
    Command failed tmp/add_2:1
    Cannot find device "ens1f0"
    Command failed tmp/add_4:1
    Cannot find device "ens1f0"
    Command failed tmp/add_3:1
    Cannot find device "ens1f0"
    Command failed tmp/add_5:1
    Cannot find device "ens1f0"
    Command failed tmp/add_6:1
    Cannot find device "ens1f0"
    Command failed tmp/add_8:1
    Cannot find device "ens1f0"
    Command failed tmp/add_7:1
    Cannot find device "ens1f0"
    Command failed tmp/add_9:1
    
    Fix the issue by executing whole compound command in namespace by wrapping
    it in 'bash -c' invocation.
    
    Fixes: 489ce2f4 ("tc-testing: Restore original behaviour for namespaces in tdc")
    Signed-off-by: default avatarVlad Buslov <vladbu@mellanox.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    14b54ac4
concurrency.json 6.39 KB