• Vasily Gorbik's avatar
    s390/topology: correct topology mode proc handler · 196851be
    Vasily Gorbik authored
    Reuse proc_douintvec_minmax to simplify topology mode proc handler.
    This also enforces correct range of 0-1 on proc writes and correctly
    handles numbers starting with 0 or spaces.
    
    Before:
    $ echo 01 > /proc/sys/s390/topology
    $ cat /proc/sys/s390/topology
    0
    $ echo ' 1' > /proc/sys/s390/topology
    -bash: echo: write error: Invalid argument
    $ echo 2 > /proc/sys/s390/topology
    -bash: echo: write error: Invalid argument
    $ echo 12 > /proc/sys/s390/topology
    $ cat /proc/sys/s390/topology
    1
    
    After:
    $ echo 01 > /proc/sys/s390/topology
    $ cat /proc/sys/s390/topology
    1
    $ echo ' 1' > /proc/sys/s390/topology
    $ cat /proc/sys/s390/topology
    1
    $ echo 2 > /proc/sys/s390/topology
    -bash: echo: write error: Invalid argument
    $ echo 12 > /proc/sys/s390/topology
    -bash: echo: write error: Invalid argument
    $ echo '   0' > /proc/sys/s390/topology
    $ cat /proc/sys/s390/topology
    0
    Reviewed-by: default avatarHeiko Carstens <heiko.carstens@de.ibm.com>
    Signed-off-by: default avatarVasily Gorbik <gor@linux.ibm.com>
    Signed-off-by: default avatarMartin Schwidefsky <schwidefsky@de.ibm.com>
    196851be
topology.c 14.2 KB