• Arnd Bergmann's avatar
    amdgpu: fix gcc -Wrestrict warning · 19c383af
    Arnd Bergmann authored
    gcc warns about an sprintf() that uses the same buffer as source
    and destination, which is undefined behavior in C99:
    
    drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c: In function 'amdgpu_securedisplay_debugfs_write':
    drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c:141:6: error: 'sprintf' argument 3 overlaps destination object 'i2c_output' [-Werror=restrict]
      141 |      sprintf(i2c_output, "%s 0x%X", i2c_output,
          |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      142 |       securedisplay_cmd->securedisplay_out_message.send_roi_crc.i2c_buf[i]);
          |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c:97:7: note: destination object referenced by 'restrict'-qualified argument 1 was declared here
       97 |  char i2c_output[256];
          |       ^~~~~~~~~~
    
    Rewrite it to remember the current offset into the buffer instead.
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
    19c383af
amdgpu_securedisplay.c 6 KB