• Jeffy Chen's avatar
    Bluetooth: btusb: Fix memory leak in play_deferred · 19cfe912
    Jeffy Chen authored
    Currently we are calling usb_submit_urb directly to submit deferred tx
    urbs after unanchor them.
    
    So the usb_giveback_urb_bh would failed to unref it in usb_unanchor_urb
    and cause memory leak:
    unreferenced object 0xffffffc0ce0fa400 (size 256):
    ...
      backtrace:
        [<ffffffc00034a9a8>] __save_stack_trace+0x48/0x6c
        [<ffffffc00034b088>] create_object+0x138/0x254
        [<ffffffc0009d5504>] kmemleak_alloc+0x58/0x8c
        [<ffffffc000345f78>] __kmalloc+0x1d4/0x2a0
        [<ffffffc0006765bc>] usb_alloc_urb+0x30/0x60
        [<ffffffbffc128598>] alloc_ctrl_urb+0x38/0x120 [btusb]
        [<ffffffbffc129e7c>] btusb_send_frame+0x64/0xf8 [btusb]
    
    Put those urbs in tx_anchor to avoid the leak, and also fix the error
    handling.
    Signed-off-by: default avatarJeffy Chen <jeffy.chen@rock-chips.com>
    Reviewed-by: default avatarOliver Neukum <oneukum@suse.com>
    Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
    19cfe912
btusb.c 87 KB