• Johan Hovold's avatar
    serial: qcom-geni: revert broken hibernation support · 19df7666
    Johan Hovold authored
    This reverts commit 35781d83.
    
    Hibernation is not supported on Qualcomm platforms with mainline
    kernels yet a broken vendor implementation for the GENI serial driver
    made it upstream.
    
    This is effectively dead code that cannot be tested and should just be
    removed, but if these paths were ever hit for an open non-console port
    they would crash the machine as the driver would fail to enable clocks
    during restore() (i.e. all ports would have to be closed by drivers and
    user space before hibernating the system to avoid this as a comment in
    the code hinted at).
    
    The broken implementation also added a random call to enable the
    receiver in the port setup code where it does not belong and which
    enables the receiver prematurely for console ports.
    
    Fixes: 35781d83 ("tty: serial: qcom-geni-serial: Add support for Hibernation feature")
    Cc: stable@vger.kernel.org	# 6.2
    Cc: Aniket Randive <quic_arandive@quicinc.com>
    Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
    Link: https://lore.kernel.org/r/20241009145110.16847-3-johan+linaro@kernel.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    19df7666
qcom_geni_serial.c 49.3 KB