• Tejun Heo's avatar
    Revert "cgroup: use an ordered workqueue for cgroup destruction" · 1a11533f
    Tejun Heo authored
    This reverts commit ab3f5faa.
    Explanation from Hugh:
    
      It's because more thorough testing, by others here, found that it
      wasn't always solving the problem: so I asked Tejun privately to
      hold off from sending it in, until we'd worked out why not.
    
      Most of our testing being on a v3,11-based kernel, it was perfectly
      possible that the problem was merely our own e.g. missing Tejun's
      8a2b7538 ("workqueue: fix ordered workqueues in NUMA setups").
    
      But that turned out not to be enough to fix it either. Then Filipe
      pointed out how percpu_ref_kill_and_confirm() uses call_rcu_sched()
      before we ever get to put the offline on to the workqueue: by the
      time we get to the workqueue, the ordering has already been lost.
    
      So, thanks for the Acks, but I'm afraid that this ordered workqueue
      solution is just not good enough: we should simply forget that patch
      and provide a different answer."
    Signed-off-by: default avatarTejun Heo <tj@kernel.org>
    Cc: Hugh Dickins <hughd@google.com>
    1a11533f
cgroup.c 147 KB