• Shuah Khan's avatar
    usbip: fix 3eee23c3ec14 tcp_socket address still in the status file · 1a2018a7
    Shuah Khan authored
    Commit 3eee23c3ec14 ("usbip: prevent vhci_hcd driver from leaking a
    socket pointer address") backported the following commit from mailine.
    However, backport error caused the tcp_socket address to still leak.
    
    commit 2f2d0088 ("usbip: prevent vhci_hcd driver from leaking a
    socket pointer address")
    
    When a client has a USB device attached over IP, the vhci_hcd driver is
    locally leaking a socket pointer address via the
    
    /sys/devices/platform/vhci_hcd/status file (world-readable) and in debug
    output when "usbip --debug port" is run.
    
    Fix it to not leak. The socket pointer address is not used at the moment
    and it was made visible as a convenient way to find IP address from
    socket pointer address by looking up /proc/net/{tcp,tcp6}.
    
    As this opens a security hole, the fix replaces socket pointer address
    with sockfd.
    Reported-by: default avatarEric Biggers <ebiggers3@gmail.com>
    Signed-off-by: default avatarShuah Khan <shuahkh@osg.samsung.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    1a2018a7
vhci_sysfs.c 6.62 KB