• ChenXiaoSong's avatar
    NFSv4: fix open failure with O_ACCMODE flag · b243874f
    ChenXiaoSong authored
    open() with O_ACCMODE|O_DIRECT flags secondly will fail.
    
    Reproducer:
      1. mount -t nfs -o vers=4.2 $server_ip:/ /mnt/
      2. fd = open("/mnt/file", O_ACCMODE|O_DIRECT|O_CREAT)
      3. close(fd)
      4. fd = open("/mnt/file", O_ACCMODE|O_DIRECT)
    
    Server nfsd4_decode_share_access() will fail with error nfserr_bad_xdr when
    client use incorrect share access mode of 0.
    
    Fix this by using NFS4_SHARE_ACCESS_BOTH share access mode in client,
    just like firstly opening.
    
    Fixes: ce4ef7c0 ("NFS: Split out NFS v4 file operations")
    Signed-off-by: default avatarChenXiaoSong <chenxiaosong2@huawei.com>
    Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
    b243874f
internal.h 25.9 KB