• Arnd Bergmann's avatar
    NFSv4.x: hide array-bounds warning · 1a42cd56
    Arnd Bergmann authored
    commit d55b352b upstream.
    
    A correct bugfix introduced a harmless warning that shows up with gcc-7:
    
    fs/nfs/callback.c: In function 'nfs_callback_up':
    fs/nfs/callback.c:214:14: error: array subscript is outside array bounds [-Werror=array-bounds]
    
    What happens here is that the 'minorversion == 0' check tells the
    compiler that we assume minorversion can be something other than 0,
    but when CONFIG_NFS_V4_1 is disabled that would be invalid and
    result in an out-of-bounds access.
    
    The added check for IS_ENABLED(CONFIG_NFS_V4_1) tells gcc that this
    really can't happen, which makes the code slightly smaller and also
    avoids the warning.
    
    The bugfix that introduced the warning is marked for stable backports,
    we want this one backported to the same releases.
    
    Fixes: 98b0f80c ("NFSv4.x: Fix a refcount leak in nfs_callback_up_net")
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    1a42cd56
callback.c 11.5 KB