• Valentine Barshak's avatar
    HID: Fix race between disconnect and hiddev_ioctl · 1a8e8fab
    Valentine Barshak authored
    A USB HID device can be disconnected at any time.
    If this happens right before or while hiddev_ioctl is in progress,
    the hiddev_ioctl tries to access invalid hiddev->hid pointer.
    When the hid device is disconnected, the hiddev_disconnect()
    ends up with a call to hid_device_release() which frees
    hid_device, but doesn't set the hiddev->hid pointer to NULL.
    If the deallocated memory region has been re-used by the kernel,
    this can cause a crash or memory corruption.
    
    Since disconnect can happen at any time, we can't initialize
    struct hid_device *hid = hiddev->hid at the beginning of ioctl
    and then use it.
    
    This change checks hiddev->exist flag while holding
    the existancelock and uses hid_device only if it exists.
    Signed-off-by: default avatarValentine Barshak <vbarshak@mvista.com>
    Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
    1a8e8fab
hiddev.c 23.8 KB