• Nikolay Aleksandrov's avatar
    bonding: clean curr_slave_lock use · 1c72cfdc
    Nikolay Aleksandrov authored
    Mostly all users of curr_slave_lock already have RTNL as we've discussed
    previously so there's no point in using it, the one case where the lock
    must stay is the 3ad code, in fact it's the only one.
    It's okay to remove it from bond_do_fail_over_mac() as it's called with
    RTNL and drops the curr_slave_lock anyway.
    bond_change_active_slave() is one of the main places where
    curr_slave_lock was used, it's okay to remove it as all callers use RTNL
    these days before calling it, that's why we move the ASSERT_RTNL() in
    the beginning to catch any potential offenders to this rule.
    The RTNL argument actually applies to all of the places where
    curr_slave_lock has been removed from in this patch.
    Also remove the unnecessary bond_deref_active_protected() macro and use
    rtnl_dereference() instead.
    Signed-off-by: default avatarNikolay Aleksandrov <nikolay@redhat.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    1c72cfdc
bond_main.c 122 KB