• Jeremy Kerr's avatar
    [POWERPC] spufs: fix save of mfc_cntl register · 1ca4264e
    Jeremy Kerr authored
    Currently, we can introduce invalid entries into the MFC queues:
    
    1) context starts a DMA
    
    2) context gets scheduled out during a DMA
      - kernel saves MFC queue to CSA
      - kernel saves 0x0 in csa->mfc_control_RW
    
    3) context gets scheduled in
      - csa->mfc_control[Q] ('queues empty') isn't set, so DMA queues are
        restored from the CSA
    
    4) context's DMA is completed
    
    5) context gets scheduled out again, no DMA occuring this time
      - kernel sees that MFC_CNTL[Q] ('queues empty') is set, so doesn't
        touch saved queue data in CSA
      - kernel saves 0x0 in csa->mfc_control_RW
    
    6) context gets scheduled in
      - csa->mfc_control[Q] ('queues empty') isn't set (we saved is as 0!),
        so DMA queues are restored from the CSA
    
    In this last restore, we've restored the queue status from step 2,
    which are now invalid.
    
    This change makes save_mfc_cntl() closer to the save/restore sequence,
    as specified in the CBE handbook.
    
    With changes from Luke Browning.
    Signed-off-by: default avatarJeremy Kerr <jk@ozlabs.org>
    1ca4264e
switch.c 62.2 KB