• David Hildenbrand's avatar
    virtio-mem: don't always trigger the workqueue when offlining memory · 1d33c2ca
    David Hildenbrand authored
    Let's trigger from offlining code only when we're not allowed to unplug
    online memory. Handle the other case (memmap possibly freeing up another
    memory block) when actually removing memory. We now also properly handle
    the case when removing already offline memory blocks via
    virtio_mem_mb_remove(). When removing via virtio_mem_remove(), when
    unloading the driver, virtio_mem_retry() is a NOP and safe to use.
    
    While at it, move retry handling when offlining out of
    virtio_mem_notify_offline(), to share it with Big Block Mode (BBM)
    soon.
    
    This is a preparation for Big Block Mode (BBM), whereby we can see some
    temporary offlining of memory blocks without actually making progress.
    Imagine you have a Big Block that spans to Linux memory blocks. Assume
    the first Linux memory blocks has no unmovable data on it. When we would
    call offline_and_remove_memory() on the big block, we would
    	1. Try to offline the first block. Works, notifiers triggered.
    	   virtio_mem_retry() called.
    	2. Try to offline the second block. Does not work.
    	3. Re-online first block.
    	4. Exit to main loop, exit workqueue.
    	5. Retry immediately (due to virtio_mem_retry()), go to 1.
    The result are endless retries.
    
    Cc: "Michael S. Tsirkin" <mst@redhat.com>
    Cc: Jason Wang <jasowang@redhat.com>
    Cc: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
    Signed-off-by: default avatarDavid Hildenbrand <david@redhat.com>
    Link: https://lore.kernel.org/r/20201112133815.13332-16-david@redhat.comSigned-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    1d33c2ca
virtio_mem.c 54.5 KB