• Lukas Czerner's avatar
    ext4: allow to change s_last_trim_minblks via sysfs · 4a69aecb
    Lukas Czerner authored
    Ext4 has an optimization mechanism for batched disacrd (FITRIM) that
    should help speed up subsequent calls of FITRIM ioctl by skipping the
    groups that were previously trimmed. However because the FITRIM allows
    to set the minimum size of an extent to trim, ext4 stores the last
    minimum extent size and only avoids trimming the group if it was
    previously trimmed with minimum extent size equal to, or smaller than
    the current call.
    
    There is currently no way to bypass the optimization without
    umount/mount cycle. This becomes a problem when the file system is
    live migrated to a different storage, because the optimization will
    prevent possibly useful discard calls to the storage.
    
    Fix it by exporting the s_last_trim_minblks via sysfs interface which
    will allow us to set the minimum size to the number of blocks larger
    than subsequent FITRIM call, effectively bypassing the optimization.
    
    By setting the s_last_trim_minblks to ULONG_MAX the optimization will be
    effectively cleared regardless of the previous state, or file system
    configuration.
    
    For example:
    getconf ULONG_MAX > /sys/fs/ext4/dm-1/last_trim_minblks
    Signed-off-by: default avatarLukas Czerner <lczerner@redhat.com>
    Reported-by: default avatarLaurent GUERBY <laurent@guerby.net>
    Reviewed-by: default avatarAndreas Dilger <adilger@dilger.ca>
    Link: https://lore.kernel.org/r/20211103145122.17338-2-lczerner@redhat.comSigned-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
    4a69aecb
sysfs.c 16.5 KB