• Oswald Buddenhagen's avatar
    ALSA: emu10k1: prune vestiges of SNDRV_SFNT_SAMPLE_{BIDIR,REVERSE}_LOOP support · 1edeac65
    Oswald Buddenhagen authored
    This is required only to implement WAVE_BIDIR_LOOP and WAVE_LOOP_BACK in
    the GUS patch loader. It has not worked on emu10k1 since before ALSA hit
    mainline, yet nobody appears to have complained. And as it isn't super
    easy to implement, just admit defeat and clean up the code.
    
    If somebody wanted to resurrect the feature, the emu8k driver could
    serve as a template, but the code would be quite different. But
    arguably, this should be done in user space in the first place, as this
    doesn't represent a hardware feature (somewhat ironically, the actual
    GUS driver has no synth support, and therefore no GUS patch loader).
    
    Note that instead of properly rejecting affected samples, we continue to
    just pretend that the feature wasn't requested. This is extremely
    questionable behavior, but avoids that possibly unused instruments
    suddenly prevent loading the entire file, which would break backwards
    compatibility. But at least we log a warning now.
    Signed-off-by: default avatarOswald Buddenhagen <oswald.buddenhagen@gmx.de>
    Message-ID: <20240406064830.1029573-6-oswald.buddenhagen@gmx.de>
    Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
    1edeac65
emu10k1_patch.c 3.93 KB