• Trond Myklebust's avatar
    NFSv4.1: Avoid false retries when RPC calls are interrupted · 3453d570
    Trond Myklebust authored
    A 'false retry' in NFSv4.1 occurs when the client attempts to transmit a
    new RPC call using a slot+sequence number combination that references an
    already cached one. Currently, the Linux NFS client will do this if a
    user process interrupts an RPC call that is in progress.
    The problem with doing so is that we defeat the main mechanism used by
    the server to differentiate between a new call and a replayed one. Even
    if the server is able to perfectly cache the arguments of the old call,
    it cannot know if the client intended to replay or send a new call.
    
    The obvious fix is to bump the sequence number pre-emptively if an
    RPC call is interrupted, but in order to deal with the corner cases
    where the interrupted call is not actually received and processed by
    the server, we need to interpret the error NFS4ERR_SEQ_MISORDERED
    as a sign that we need to either wait or locate a correct sequence
    number that lies between the value we sent, and the last value that
    was acked by a SEQUENCE call on that slot.
    Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
    Tested-by: default avatarJason Tibbitts <tibbs@math.uh.edu>
    3453d570
nfs4session.c 16.7 KB