• Jarek Poplawski's avatar
    [NETPOLL]: Fixups for 'fix soft lockup when removing module' · 25442caf
    Jarek Poplawski authored
    >From my recent patch:
    
    > >    #1
    > >    Until kernel ver. 2.6.21 (including) cancel_rearming_delayed_work()
    > >    required a work function should always (unconditionally) rearm with
    > >    delay > 0 - otherwise it would endlessly loop. This patch replaces
    > >    this function with cancel_delayed_work(). Later kernel versions don't
    > >    require this, so here it's only for uniformity.
    
    But Oleg Nesterov <oleg@tv-sign.ru> found:
    
    > But 2.6.22 doesn't need this change, why it was merged?
    > 
    > In fact, I suspect this change adds a race,
    ...
    
    His description was right (thanks), so this patch reverts #1.
    Signed-off-by: default avatarJarek Poplawski <jarkao2@o2.pl>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    25442caf
netpoll.c 18.8 KB