• Christoph Hellwig's avatar
    [PATCH] inode time update funnies in ncpfs · 20aa19ae
    Christoph Hellwig authored
    ncfpfs seems to update inode times by hand everywhere instead of using
    the proper helpers.  This means:
    
     - the atime updates in mmap() and read() seems to miss various checks
       upodate_atime or one of the wrappers does.  Also it doesn't mark the
       inode dirty.
     - in write() you update mtime and _a_time instead of ctime as expected,
       also the usual checks and optimizations are missing.
    
    In addition the fops contain some bogus checks like for a refular file (but
    the fops are only used of ISREG files) and inode->i_sb although that is
    guranteed to be non-zero.
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    20aa19ae
mmap.c 2.94 KB