• Gustavo A. R. Silva's avatar
    scsi: virtio_scsi: Use struct_size() helper · 211f70ff
    Gustavo A. R. Silva authored
    One of the more common cases of allocation size calculations is finding
    the size of a structure that has a zero-sized array at the end, along
    with memory for some number of elements for that array. For example:
    
    struct virtio_scsi {
    	...
            struct virtio_scsi_vq req_vqs[];
    };
    
    Make use of the struct_size() helper instead of an open-coded version
    in order to avoid any potential type mistakes.
    
    So, replace the following form:
    
    sizeof(*vscsi) + sizeof(vscsi->req_vqs[0]) * num_queues
    
    with:
    
    struct_size(vscsi, req_vqs, num_queues)
    
    This code was detected with the help of Coccinelle.
    Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
    Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    211f70ff
virtio_scsi.c 24.9 KB