• Guenter Roeck's avatar
    hwmon: (nct6775) Let enum kinds start with index 0 · 22558934
    Guenter Roeck authored
    Commit 10a0575e ("hwmon: (nct6775-i2c) Use i2c_get_match_data()")
    introduced calling i2c_get_match_data() to the nct6775 driver. As part
    of that commit, enum kinds was changed to start with 1, based on
    
        Adjust the 'kinds' enum to not use 0, so that no match data can be
        distinguished from a valid enum value.
    
    The patch had to be fixed later with commit 2792fc8f ("hwmon:
    (nct6775-core) Explicitly initialize nct6775_device_names indexes") and
    commit efe86092 ("hwmon: (nct6775-platform) Explicitly initialize
    nct6775_sio_names indexes").
    
    Various patches submitted later show that the change from 0 to 1 is
    not really necessary. As it turns out, it is perfectly fine as long as
    there is an i2c_device_id array with the same data as in the of_device_id
    array. This data is used as fallback if the data pointer in struct
    of_device_id is NULL (0).
    
    Let enum chips start with 0 to avoid confusion against other drivers
    where the enum starts with 0 and i2c_get_match_data() is used as well.
    Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
    22558934
nct6775.h 7.23 KB