• Tong Li's avatar
    [PATCH] OProfile: fixed x86_64 incorrect kernel call graphs · 23332c2e
    Tong Li authored
    Fix the problem in kernel 2.6.15.1 (and early versions) that OProfile on
    x86_64 does not correctly collect the stack traces for kernel functions.
    
    The original code in valid_kernel_stack() in arch/i386/oprofile/backtrace.c
    assumes that the frame pointer (headaddr) should be greater than stack
    (i.e., regs).
    
    This assumption is wrong for x86_64 because NMIs in x86_64 use a seperate
    stack different from the kernel stack.  Therefore, the variable stack now
    points to some location on the NMI stack, which turns out to be at a higher
    address than the frame pointer (headaddr) on the kernel stack.  The correct
    comparison here should be between headaddr and regs->rsp for x86_64.
    Signed-off-by: default avatarTong Li <tong.n.li@intel.com>
    Cc: John Levon <levon@movementarian.org>
    Cc: Philippe Elie <phil.el@wanadoo.fr>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    23332c2e
backtrace.c 2.97 KB