• Jon Maloy's avatar
    tipc: fix lost member events bug · 23483399
    Jon Maloy authored
    Group messages are not supposed to be returned to sender when the
    destination socket disappears. This is done correctly for regular
    traffic messages, by setting the 'dest_droppable' bit in the header.
    But we forget to do that in group protocol messages. This has the effect
    that such messages may sometimes bounce back to the sender, be perceived
    as a legitimate peer message, and wreak general havoc for the rest of
    the session. In particular, we have seen that a member in state LEAVING
    may go back to state RECLAIMED or REMITTED, hence causing suppression
    of an otherwise expected 'member down' event to the user.
    
    We fix this by setting the 'dest_droppable' bit even in group protocol
    messages.
    Signed-off-by: default avatarJon Maloy <jon.maloy@ericsson.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    23483399
group.c 21.6 KB