• John Garry's avatar
    perf pmu: Fix alias events list · e0257a01
    John Garry authored
    Commit 0e0ae874 ("perf list: Display hybrid PMU events with cpu
    type") changes the event list for uncore PMUs or arm64 heterogeneous CPU
    systems, such that duplicate aliases are incorrectly listed per PMU
    (which they should not be), like:
    
      # perf list
      ...
      unc_cbo_cache_lookup.any_es
      [Unit: uncore_cbox L3 Lookup any request that access cache and found
      line in E or S-state]
      unc_cbo_cache_lookup.any_es
      [Unit: uncore_cbox L3 Lookup any request that access cache and found
      line in E or S-state]
      unc_cbo_cache_lookup.any_i
      [Unit: uncore_cbox L3 Lookup any request that access cache and found
      line in I-state]
      unc_cbo_cache_lookup.any_i
      [Unit: uncore_cbox L3 Lookup any request that access cache and found
      line in I-state]
      ...
    
    Notice how the events are listed twice.
    
    The named commit changed how we remove duplicate events, in that events
    for different PMUs are not treated as duplicates. I suppose this is to
    handle how "Each hybrid pmu event has been assigned with a pmu name".
    
    Fix PMU alias listing by restoring behaviour to remove duplicates for
    non-hybrid PMUs.
    
    Fixes: 0e0ae874 ("perf list: Display hybrid PMU events with cpu type")
    Signed-off-by: default avatarJohn Garry <john.garry@huawei.com>
    Tested-by: default avatarZhengjun Xing <zhengjun.xing@linux.intel.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Ian Rogers <irogers@google.com>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Kan Liang <kan.liang@linux.intel.com>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: https://lore.kernel.org/r/1640103090-140490-1-git-send-email-john.garry@huawei.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    e0257a01
pmu.c 42.7 KB