• Ruihan Li's avatar
    bluetooth: Perform careful capability checks in hci_sock_ioctl() · 25c150ac
    Ruihan Li authored
    Previously, capability was checked using capable(), which verified that the
    caller of the ioctl system call had the required capability. In addition,
    the result of the check would be stored in the HCI_SOCK_TRUSTED flag,
    making it persistent for the socket.
    
    However, malicious programs can abuse this approach by deliberately sharing
    an HCI socket with a privileged task. The HCI socket will be marked as
    trusted when the privileged task occasionally makes an ioctl call.
    
    This problem can be solved by using sk_capable() to check capability, which
    ensures that not only the current task but also the socket opener has the
    specified capability, thus reducing the risk of privilege escalation
    through the previously identified vulnerability.
    
    Cc: stable@vger.kernel.org
    Fixes: f81f5b2d ("Bluetooth: Send control open and close messages for HCI raw sockets")
    Signed-off-by: default avatarRuihan Li <lrh2000@pku.edu.cn>
    Signed-off-by: default avatarLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
    25c150ac
hci_sock.c 48 KB