• Lu Baolu's avatar
    driver core: Add dma_cleanup callback in bus_type · 25f3bcfc
    Lu Baolu authored
    The bus_type structure defines dma_configure() callback for bus drivers
    to configure DMA on the devices. This adds the paired dma_cleanup()
    callback and calls it during driver unbinding so that bus drivers can do
    some cleanup work.
    
    One use case for this paired DMA callbacks is for the bus driver to check
    for DMA ownership conflicts during driver binding, where multiple devices
    belonging to a same IOMMU group (the minimum granularity of isolation and
    protection) may be assigned to kernel drivers or user space respectively.
    
    Without this change, for example, the vfio driver has to listen to a bus
    BOUND_DRIVER event and then BUG_ON() in case of dma ownership conflict.
    This leads to bad user experience since careless driver binding operation
    may crash the system if the admin overlooks the group restriction. Aside
    from bad design, this leads to a security problem as a root user, even with
    lockdown=integrity, can force the kernel to BUG.
    
    With this change, the bus driver could check and set the DMA ownership in
    driver binding process and fail on ownership conflicts. The DMA ownership
    should be released during driver unbinding.
    Signed-off-by: default avatarLu Baolu <baolu.lu@linux.intel.com>
    Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    Reviewed-by: default avatarJason Gunthorpe <jgg@nvidia.com>
    Link: https://lore.kernel.org/r/20220418005000.897664-3-baolu.lu@linux.intel.comSigned-off-by: default avatarJoerg Roedel <jroedel@suse.de>
    25f3bcfc
dd.c 34.1 KB