• Daniel Wagner's avatar
    nvme-fabrics: show well known discovery name · 26a57cb3
    Daniel Wagner authored
    The kernel always logs the unique subsystem name for a discovery
    controller, even in the case user space asked for the well known.
    
    This has lead to confusion as the logs of nvme-cli and the kernel
    logs didn't match.
    
    First, nvme-cli connects to the well known discovery controller to
    figure out if it supports TP8013. If so then nvme-cli disconnects and
    connects to the unique discovery controller. Currently, the kernel show
    that user space connected twice to the unique one.
    
    To avoid further confusion, show the well known discovery controller if
    user space asked for it:
    
      $ nvme connect-all -v -t tcp -a 192.168.0.1
      nvme0: nqn.2014-08.org.nvmexpress.discovery connected
      nvme0: nqn.2014-08.org.nvmexpress.discovery disconnected
      nvme0: nqn.discovery connected
    
      kernel log:
      nvme nvme0: new ctrl: NQN "nqn.2014-08.org.nvmexpress.discovery", addr 192.168.0.1:8009
      nvme nvme0: Removing ctrl: NQN "nqn.2014-08.org.nvmexpress.discovery"
      nvme nvme0: new ctrl: NQN "nqn.discovery", addr 192.168.0.1:8009
    
    Fixes: e5ea42fa ("nvme: display correct subsystem NQN")
    Signed-off-by: default avatarDaniel Wagner <dwagner@suse.de>
    Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
    Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
    26a57cb3
fabrics.h 7.72 KB