• Chao Yu's avatar
    f2fs: fix to force keeping write barrier for strict fsync mode · 27879915
    Chao Yu authored
    [1] https://www.mail-archive.com/linux-f2fs-devel@lists.sourceforge.net/msg15126.html
    
    As [1] reported, if lower device doesn't support write barrier, in below
    case:
    
    - write page #0; persist
    - overwrite page #0
    - fsync
     - write data page #0 OPU into device's cache
     - write inode page into device's cache
     - issue flush
    
    If SPO is triggered during flush command, inode page can be persisted
    before data page #0, so that after recovery, inode page can be recovered
    with new physical block address of data page #0, however there may
    contains dummy data in new physical block address.
    
    Then what user will see is: after overwrite & fsync + SPO, old data in
    file was corrupted, if any user do care about such case, we can suggest
    user to use STRICT fsync mode, in this mode, we will force to use atomic
    write sematics to keep write order in between data/node and last node,
    so that it avoids potential data corruption during fsync().
    Signed-off-by: default avatarChao Yu <chao@kernel.org>
    Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
    27879915
file.c 106 KB