• Chengfeng Ye's avatar
    ocfs2: cluster: fix potential deadlock on &qs->qs_lock · 28a45ef8
    Chengfeng Ye authored
    &qs->qs_lock is acquired by timer o2net_idle_timer() along the following
    call chain.  Thus the acquisition of the lock under process context should
    disable bottom half, otherwise deadlock could happen if the timer happens
    to preempt the execution while the lock is held in process context on the
    same CPU.
    
    <timer interrupt>
            -> o2net_idle_timer()
            -> o2quo_conn_err()
            -> spin_lock(&qs->qs_lock)
    
    Several lock acquisition of &qs->qs_lock under process contex do not
    disable irq or bottom half.  The patch fixes these potential deadlocks
    scenerio by using spin_lock_bh() on &qs->qs_lock.
    
    This flaw was found by an experimental static analysis tool I am
    developing for irq-related deadlock.  x86_64 allmodconfig using gcc shows
    no new warning.
    
    Link: https://lkml.kernel.org/r/20230802123824.15301-1-dg573847474@gmail.comSigned-off-by: default avatarChengfeng Ye <dg573847474@gmail.com>
    Cc: Mark Fasheh <mark@fasheh.com>
    Cc: Joel Becker <jlbec@evilplan.org>
    Cc: Junxiao Bi <junxiao.bi@oracle.com>
    Cc: Joseph Qi <jiangqi903@gmail.com>
    Cc: Gang He <ghe@suse.com>
    Cc: Jun Piao <piaojun@huawei.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    28a45ef8
quorum.c 9.66 KB