• Vinicius Costa Gomes's avatar
    sched: etf: Fix ordering of packets with same txtime · 28aa7c86
    Vinicius Costa Gomes authored
    When a application sends many packets with the same txtime, they may
    be transmitted out of order (different from the order in which they
    were enqueued).
    
    This happens because when inserting elements into the tree, when the
    txtime of two packets are the same, the new packet is inserted at the
    left side of the tree, causing the reordering. The only effect of this
    change should be that packets with the same txtime will be transmitted
    in the order they are enqueued.
    
    The application in question (the AVTP GStreamer plugin, still in
    development) is sending video traffic, in which each video frame have
    a single presentation time, the problem is that when packetizing,
    multiple packets end up with the same txtime.
    
    The receiving side was rejecting packets because they were being
    received out of order.
    
    Fixes: 25db26a9 ("net/sched: Introduce the ETF Qdisc")
    Reported-by: default avatarEderson de Souza <ederson.desouza@intel.com>
    Signed-off-by: default avatarVinicius Costa Gomes <vinicius.gomes@intel.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    28aa7c86
sch_etf.c 11.6 KB