• Andrea Arcangeli's avatar
    mm: gup: allow FOLL_PIN to scale in SMP · 292648ac
    Andrea Arcangeli authored
    has_pinned cannot be written by each pin-fast or it won't scale in SMP.
    This isn't "false sharing" strictly speaking (it's more like "true
    non-sharing"), but it creates the same SMP scalability bottleneck of
    "false sharing".
    
    To verify the improvement, below test is done on 40 cpus host with
    Intel(R) Xeon(R) CPU E5-2630 v4 @ 2.20GHz (must be with
    CONFIG_GUP_TEST=y):
    
      $ sudo chrt -f 1 ./gup_test -a  -m 512 -j 40
    
    Where we can get (average value for 40 threads):
    
      Old kernel: 477729.97 (+- 3.79%)
      New kernel:  89144.65 (+-11.76%)
    
    On a similar condition with 256 cpus, this commits increases the SMP
    scalability of pin_user_pages_fast() executed by different threads of the
    same process by more than 4000%.
    
    [peterx@redhat.com: rewrite commit message, add parentheses against "(A & B)"]
    
    Link: https://lkml.kernel.org/r/20210507150553.208763-3-peterx@redhat.comSigned-off-by: default avatarAndrea Arcangeli <aarcange@redhat.com>
    Signed-off-by: default avatarPeter Xu <peterx@redhat.com>
    Reviewed-by: default avatarJohn Hubbard <jhubbard@nvidia.com>
    Cc: Hugh Dickins <hughd@google.com>
    Cc: Jan Kara <jack@suse.cz>
    Cc: Jann Horn <jannh@google.com>
    Cc: Jason Gunthorpe <jgg@nvidia.com>
    Cc: Kirill Shutemov <kirill@shutemov.name>
    Cc: Kirill Tkhai <ktkhai@virtuozzo.com>
    Cc: Matthew Wilcox <willy@infradead.org>
    Cc: Michal Hocko <mhocko@suse.com>
    Cc: Oleg Nesterov <oleg@redhat.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    292648ac
gup.c 83.5 KB