• Julia Lawall's avatar
    [S390]: Fix use of skb after netif_rx · 9b3efc01
    Julia Lawall authored
    Recently, Wang Chen submitted a patch
    (d30f53ae) to move a call to netif_rx(skb)
    after a subsequent reference to skb, because netif_rx may call kfree_skb on
    its argument.  netif_rx_ni calls netif_rx, so the same problem occurs in
    the files below.
    
    I have left the updating of dev->last_rx after the calls to netif_rx_ni
    because it seems time dependent, but moved the other field updates before.
    
    This was found using the following semantic match.
    (http://www.emn.fr/x-info/coccinelle/)
    
    // <smpl>
    @@
    expression skb, e,e1;
    @@
    
    (
     netif_rx(skb);
    |
     netif_rx_ni(skb);
    )
      ... when != skb = e
    (
      skb = e1
    |
    * skb
    )
    // </smpl>
    Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    9b3efc01
ctcmain.c 81.4 KB