• David Howells's avatar
    rxrpc: Fix handling of rwind from an ACK packet · a2ad7c21
    David Howells authored
    The handling of the receive window size (rwind) from a received ACK packet
    is not correct.  The rxrpc_input_ackinfo() function currently checks the
    current Tx window size against the rwind from the ACK to see if it has
    changed, but then limits the rwind size before storing it in the tx_winsize
    member and, if it increased, wake up the transmitting process.  This means
    that if rwind > RXRPC_RXTX_BUFF_SIZE - 1, this path will always be
    followed.
    
    Fix this by limiting rwind before we compare it to tx_winsize.
    
    The effect of this can be seen by enabling the rxrpc_rx_rwind_change
    tracepoint.
    
    Fixes: 702f2ac8 ("rxrpc: Wake up the transmitter if Rx window size increases on the peer")
    Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
    a2ad7c21
input.c 37.3 KB